Fixes #344 #348
Merged
Fixes #344 #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like how the final changes look. Purely technical comment : the commits history is starting to get a bit messy for a "small" resulting diff, would you mind squashing your 6 commits into one, and PS: PRs are exactly the places where you want to ignore the note at the end of the linked article :p |
Examples for DNFs in Fewest Moves scrambling -> scramble Clarified E2e again Added clarifiction scrambling algorithm -> scramble sequence
|
Good idea! :-) |
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #344 for a longer explanation.
These changes clarify that E2e can also be relevant when there is no proof that a competitor used the scramble sequence to derive his solution intentionally.
With the new Fewest Moves scramble sequences implemented in TNoodle, starting a solution with the inverse of more than the last 4 moves of the scramble is a good evidence that the solution was derived from the scramble as the first and the last three moves of the scramble sequence are pointless. However, this is still a "should", so in the rare case that beginning a solution with these moves is reasonable, this is not necessarily a DNF.
Question
Is "solutions beginning with more than 4 moves of the inverse scramble sequence" clear?
It can be interpreted that solutions should not begin with any 4 moves of the inverse scramble. But I have no idea how to clarify that here.